feat: profile mobile view - #62646
Conversation
There was a problem hiding this comment.
Should not be committed I guess?
There was a problem hiding this comment.
Please put compiled assets into a second commit.
Also you do not need them on CI - usually they just conflict soon so I recommend only compiling them after the PR was reviewed :)
4a4f964 to
e82f5fe
Compare
|
@kristian-zendato in the future, please add me, or whoever the relevant designer is as a reviewer and attach screenshots for visual changes so that designers can also evaluate the implementation :) |
29792e3 to
73bc5f6
Compare
|
@kra-mo I added screenshot for the update. |
73bc5f6 to
ea88fd3
Compare
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Some nits otherwise seems to be fine :)
| :disableMenu="true" | ||
| :disableTooltip="true" |
There was a problem hiding this comment.
| :disableMenu="true" | |
| :disableTooltip="true" | |
| disableMenu | |
| disableTooltip |
| variant="primary" | ||
| class="user-actions__primary" | ||
| :href="settingsUrl"> | ||
| {{ t('profile', 'Edit Profile') }} |
There was a problem hiding this comment.
We use sentence case ( https://docs.nextcloud.com/server/stable/developer_manual/design/writing.html )
| {{ t('profile', 'Edit Profile') }} | |
| {{ t('profile', 'Edit profile') }} |
| <template #icon> | ||
| <PencilIcon :size="20" /> | ||
| </template> | ||
| {{ t('profile', 'Edit Profile') }} |
There was a problem hiding this comment.
| {{ t('profile', 'Edit Profile') }} | |
| {{ t('profile', 'Edit profile') }} |
ea88fd3 to
c988f8d
Compare
Signed-off-by: Kristian Zendato <kristian.zendato@nextcloud.com>
c988f8d to
d91b913
Compare
3 participants
Summary
Update profile view on mobile layout
Edit Profilebutton as a primary action button🖼️ Screenshots / Screencasts
Checklist
3. to review, feature component)stable32)AI (if applicable)